[cmake] Skip regex when CMAKE_STATIC_LIBRARY_PREFIX is empty. #452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In platforms like Windows, there's no prefix for static libraries. Interpolating it in the regex will end up with a regex "^", which seems not to be valid. Since the regex was removing the prefix, we can simply skip the operation and the result will be the same. Also do the same for CMAKE_STATIC_LIBRARY_SUFFIX, even if in that case, Windows will have a value (but if it is empty, it will fail trying to create the regex).
|
Same fix in foundation: swiftlang/swift-corelibs-foundation#1971 |
|
@swift-ci please test |
ktopley-apple
approved these changes
Mar 21, 2019
|
@swift-ci please test |
compnerd
approved these changes
Mar 21, 2019
rokhinip
pushed a commit
that referenced
this pull request
Nov 5, 2021
[cmake] Skip regex when CMAKE_STATIC_LIBRARY_PREFIX is empty. Signed-off-by: Kim Topley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In platforms like Windows, there's no prefix for static libraries.
Interpolating it in the regex will end up with a regex "^", which seems
not to be valid. Since the regex was removing the prefix, we can simply
skip the operation and the result will be the same.
Also do the same for CMAKE_STATIC_LIBRARY_SUFFIX, even if in that case,
Windows will have a value (but if it is empty, it will fail trying to
create the regex).